[WOOMOB-2397][POS Refunds M2] Part 2: Refunded items UI by samiuelson · Pull Request #15489 · woocommerce/woocommerce-android

samiuelson · 2026-03-05T17:52:55Z

Description

Adds the UI layer for displaying refunded line items in POS order details. This is the second of two PRs for WOOMOB-2397, building on #15488.

Changes:

Add ProductsSection composable that handles LineItemsState (loading shimmer / loaded items)
Add RefundedProductsSection composable for displaying refunded items
Add ProductsShimmer composable for loading state placeholder
Extract title parameter in OrdersProducts for reuse between products and refunded sections
Update previews with refunded items sample data
Add "Refunded Products" string resource

Testing instructions

Open POS and complete an order
Issue a partial refund for one item
Open order details
Verify "Products" section shows non-refunded items
Verify "Refunded Products" section appears with refunded items
Verify shimmer loading state appears briefly while refund data loads

Images/Gif

Screen_recording_20260306_170224.mp4

wpmobilebot · 2026-03-05T18:15:20Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Build Number	`732`
	Version	`24.3-rc-1`
	Application ID	`com.woocommerce.android.prealpha`
	Commit	`3628f02`
	Installation URL	08fk144q3h7pg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...merce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/details/WooPosOrderDetails.kt

codecov-commenter · 2026-03-06T16:29:15Z

Codecov Report

❌ Patch coverage is 17.14286% with 87 lines in your changes missing coverage. Please review.
✅ Project coverage is 39.53%. Comparing base (969ebd6) to head (3628f02).
⚠️ Report is 26 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...oid/ui/woopos/orders/details/WooPosOrderDetails.kt	0.00%	85 Missing ⚠️
.../woopos/orders/details/WooPosOrderDetailsMapper.kt	88.88%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk   #15489      +/-   ##
============================================
- Coverage     39.54%   39.53%   -0.02%     
  Complexity    11223    11223              
============================================
  Files          2252     2252              
  Lines        129459   129543      +84     
  Branches      18127    18142      +15     
============================================
+ Hits          51201    51212      +11     
- Misses        73029    73103      +74     
+ Partials       5229     5228       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

malinajirka

Thanks @samiuelson !

The changes look good and work as expected. The only thing which feels a bit off to me as a user - not technically related to this PR - is that the product row is without taxes:

...merce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/details/WooPosOrderDetails.kt

Add ProductsSection, RefundedProductsSection, and ProductsShimmer composables to display refunded line items with loading state support. Update previews to include refunded items sample data.

samiuelson · 2026-03-09T15:44:41Z

Thanks for review, @malinajirka!

The changes look good and work as expected. The only thing which feels a bit off to me as a user - not technically related to this PR - is that the product row is without taxes

I'm not sure if it's a good idea, because this would make the display logic inconsistent across Products and Refunded Products sections. In Products totals are displayed without taxes as well.

In the next milestone M3, we are going to show more details of refund:

I think this will solve the issue. Let me know what you think!

malinajirka · 2026-03-09T16:09:36Z

The changes look good and work as expected. The only thing which feels a bit off to me as a user - not technically related to this PR - is that the product row is without taxes

I'm not sure if it's a good idea, because this would make the display logic inconsistent across Products and Refunded Products sections. In Products totals are displayed without taxes as well.

I wasn't suggesting we should show tax for refunded items but not show it for product items. I just pointed out that this part feels weird to me as a user.

When I have an order with 5 products and no refunds, it's relatively natural, that product rows are without taxes and all taxes are sumed up below. However, when I have an order with 1 product and 2 refunded products, it feels a bit weird. I'm not sure what the solution is though - especially, since the backend likely doesn't tell us per-item-tax.

P.S. I noticed that the Apple ring on this order has negative sign -> we might want to consider using abs here as well.

samiuelson · 2026-03-09T16:15:03Z

When I have an order with 5 products and no refunds, it's relatively natural, that product rows are without taxes and all taxes are sumed up below. However, when I have an order with 1 product and 2 refunded products, it feels a bit weird. I'm not sure what the solution is though - especially, since the backend likely doesn't tell us per-item-tax.

Got it. To me this feels good enough, assuming we'll have the total taxes shown in the list/details of historical refunds in the Totals section. Though, I'll ask for a designer's feedback during call for testing, likely tomorrow.

P.S. I noticed that the Apple ring on this order has negative sign -> we might want to consider using abs here as well.

This has been fixed within 5f8c4f9.

samiuelson changed the title ~~Add refunded items UI for POS order details~~ [WOOMOB-2397][POS Refunds M2] Part 2: Refunded items UI Mar 5, 2026

samiuelson mentioned this pull request Mar 5, 2026

[WOOMOB-2397][POS Refunds M2] Part 1: Refunded items data layer #15488

Merged

samiuelson requested a review from Copilot March 5, 2026 18:02

This comment was marked as off-topic.

Sign in to view

samiuelson force-pushed the woomob-2397-ui branch from cfff720 to 4f93620 Compare March 6, 2026 15:19

samiuelson requested a review from Copilot March 6, 2026 15:19

Copilot started reviewing on behalf of samiuelson March 6, 2026 15:20 View session

Copilot AI reviewed Mar 6, 2026

View reviewed changes

...merce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/details/WooPosOrderDetails.kt Show resolved Hide resolved

samiuelson added this to the 24.4 milestone Mar 6, 2026

samiuelson added the feature: point of sale POS project label Mar 6, 2026

samiuelson requested a review from malinajirka March 6, 2026 16:05

malinajirka self-assigned this Mar 9, 2026

malinajirka approved these changes Mar 9, 2026

View reviewed changes

...merce/src/main/kotlin/com/woocommerce/android/ui/woopos/orders/details/WooPosOrderDetails.kt Show resolved Hide resolved

samiuelson added 4 commits March 9, 2026 16:26

Add refunded items UI for POS order details

b7014fc

Add ProductsSection, RefundedProductsSection, and ProductsShimmer composables to display refunded line items with loading state support. Update previews to include refunded items sample data.

Aggregate totalTax when grouping refunded items

4de6508

Skip products shimmer for fully refunded orders

87c10d5

Display refunded items prices excluding tax and as positive amounts

5f8c4f9

samiuelson force-pushed the woomob-2397-ui branch from 4f93620 to 5f8c4f9 Compare March 9, 2026 15:40

Base automatically changed from woomob-2397-data-layer to trunk March 9, 2026 15:45

Merge branch 'trunk' into woomob-2397-ui

3628f02

samiuelson enabled auto-merge March 9, 2026 16:59

samiuelson merged commit 7c7df1e into trunk Mar 9, 2026
15 of 16 checks passed

samiuelson deleted the woomob-2397-ui branch March 9, 2026 17:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WOOMOB-2397][POS Refunds M2] Part 2: Refunded items UI #15489

[WOOMOB-2397][POS Refunds M2] Part 2: Refunded items UI #15489
samiuelson merged 5 commits intotrunkfrom
woomob-2397-ui

samiuelson commented Mar 5, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Mar 5, 2026 •

edited

Loading

Uh oh!

This comment was marked as off-topic.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

codecov-commenter commented Mar 6, 2026 •

edited

Loading

Uh oh!

malinajirka left a comment

Uh oh!

Uh oh!

samiuelson commented Mar 9, 2026

Uh oh!

malinajirka commented Mar 9, 2026

Uh oh!

samiuelson commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

samiuelson commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Images/Gif

Uh oh!

wpmobilebot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as off-topic.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

codecov-commenter commented Mar 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

malinajirka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

samiuelson commented Mar 9, 2026

Uh oh!

malinajirka commented Mar 9, 2026

Uh oh!

samiuelson commented Mar 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

samiuelson commented Mar 5, 2026 •

edited

Loading

wpmobilebot commented Mar 5, 2026 •

edited

Loading

codecov-commenter commented Mar 6, 2026 •

edited

Loading